Skip to content

Fix enable_async for aiohttp and sanic #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2020
Merged

Fix enable_async for aiohttp and sanic #67

merged 5 commits into from
Oct 17, 2020

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Oct 15, 2020

Resolves #64 using the fix suggested by ketanbshah.

I admit that I am not positive the fix is required for sanic, but it should not hurt, and the original code was identical.

@r-owen r-owen changed the title Fix enable_async for aiohttp and sanic; thanks to ketanbshah Fix enable_async for aiohttp and sanic Oct 15, 2020
@r-owen
Copy link
Contributor Author

r-owen commented Oct 15, 2020

The tests all pass for me on my computer.

@KingDarBoja KingDarBoja added the type: bug An issue or pull request relating to a bug label Oct 17, 2020
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution, I added extra tests for checking out this.

@KingDarBoja KingDarBoja merged commit e39398a into graphql-python:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql-server v3.0.0b1 does not work with aiohttp in async mode with graphiql
2 participants