Modified: python*/runner/sensei.py to fix progress message. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous sensei message tells the user they are "{completed}/
{total} lessons away from enlightenment." This is not a true
statement since your fractional progress is not equal to your
distance from enlightenment. I have modified the report_progress
function to return a two line string. The first line reports the
total progress and the second line tells them they are {total-
completed} koans away from enlightenment.
I modified report_progress() in both python2/runner/sensei.py
and python3/runner/sensei.py
gregmalcolm
added a commit
that referenced
this pull request
Feb 16, 2013
Modified: python*/runner/sensei.py to fix progress message.
|
Thanks! That does look cleaner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous sensei message tells the user they are "{completed}/
{total} lessons away from enlightenment." This is not a true
statement since your fractional progress is not equal to your
distance from enlightenment. I have modified the report_progress
function to return a two line string. The first line reports the
total progress and the second line tells them they are {total-
completed} koans away from enlightenment.
I modified report_progress() in both python2/runner/sensei.py
and python3/runner/sensei.py