chore: rename 'Deployment' button to 'Administration' (coder#14240)

Emyrk · web-flow · commit ccc664de37a4 · 2024-08-13T11:21:02.000-05:00
* chore: rename 'Deployment' button to 'Administration' 

Reword "Auditing" to a noun like the rest of the dropdowns
diff --git a/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx b/site/src/modules/dashboard/Navbar/DeploymentDropdown.tsx
@@ -52,7 +52,7 @@ export const DeploymentDropdown: FC<DeploymentDropdownProps> = ({
             />
           }
         >
-          Deployment
+          Administration
         </Button>
       </PopoverTrigger>
 
@@ -128,7 +128,7 @@ const DeploymentDropdownContent: FC<DeploymentDropdownProps> = ({
           css={styles.menuItem}
           onClick={onPopoverClose}
         >
-          Auditing
+          Audit Logs
         </MenuItem>
       )}
       {canViewHealth && (
diff --git a/site/src/modules/dashboard/Navbar/Navbar.test.tsx b/site/src/modules/dashboard/Navbar/Navbar.test.tsx
@@ -22,7 +22,7 @@ describe("Navbar", () => {
       }),
     );
     render(<App />);
-    const deploymentMenu = await screen.findByText("Deployment");
+    const deploymentMenu = await screen.findByText("Administration");
     await userEvent.click(deploymentMenu);
     await waitFor(
       () => {
@@ -37,7 +37,7 @@ describe("Navbar", () => {
     // by default, user is an Admin with permission to see the audit log,
     // but is unlicensed so not entitled to see the audit log
     render(<App />);
-    const deploymentMenu = await screen.findByText("Deployment");
+    const deploymentMenu = await screen.findByText("Administration");
     await userEvent.click(deploymentMenu);
     await waitFor(
       () => {
diff --git a/site/src/modules/dashboard/Navbar/NavbarView.stories.tsx b/site/src/modules/dashboard/Navbar/NavbarView.stories.tsx
@@ -26,7 +26,9 @@ type Story = StoryObj<typeof NavbarView>;
 export const ForAdmin: Story = {
   play: async ({ canvasElement }) => {
     const canvas = within(canvasElement);
-    await userEvent.click(canvas.getByRole("button", { name: "Deployment" }));
+    await userEvent.click(
+      canvas.getByRole("button", { name: "Administration" }),
+    );
   },
 };
 
@@ -41,7 +43,9 @@ export const ForAuditor: Story = {
   },
   play: async ({ canvasElement }) => {
     const canvas = within(canvasElement);
-    await userEvent.click(canvas.getByRole("button", { name: "Deployment" }));
+    await userEvent.click(
+      canvas.getByRole("button", { name: "Administration" }),
+    );
   },
 };
 
@@ -56,7 +60,9 @@ export const ForOrgAdmin: Story = {
   },
   play: async ({ canvasElement }) => {
     const canvas = within(canvasElement);
-    await userEvent.click(canvas.getByRole("button", { name: "Deployment" }));
+    await userEvent.click(
+      canvas.getByRole("button", { name: "Administration" }),
+    );
   },
 };
 
diff --git a/site/src/modules/dashboard/Navbar/NavbarView.test.tsx b/site/src/modules/dashboard/Navbar/NavbarView.test.tsx
@@ -69,7 +69,7 @@ describe("NavbarView", () => {
         canViewAuditLog
       />,
     );
-    const deploymentMenu = await screen.findByText("Deployment");
+    const deploymentMenu = await screen.findByText("Administration");
     await userEvent.click(deploymentMenu);
     const userLink = await screen.findByText(navLanguage.users);
     expect((userLink as HTMLAnchorElement).href).toContain("/users");
@@ -88,7 +88,7 @@ describe("NavbarView", () => {
         canViewAuditLog
       />,
     );
-    const deploymentMenu = await screen.findByText("Deployment");
+    const deploymentMenu = await screen.findByText("Administration");
     await userEvent.click(deploymentMenu);
     const auditLink = await screen.findByText(navLanguage.audit);
     expect((auditLink as HTMLAnchorElement).href).toContain("/audit");
@@ -107,7 +107,7 @@ describe("NavbarView", () => {
         canViewAuditLog
       />,
     );
-    const deploymentMenu = await screen.findByText("Deployment");
+    const deploymentMenu = await screen.findByText("Administration");
     await userEvent.click(deploymentMenu);
     const deploymentSettingsLink = await screen.findByText(
       navLanguage.deployment,
diff --git a/site/src/modules/dashboard/Navbar/NavbarView.tsx b/site/src/modules/dashboard/Navbar/NavbarView.tsx
@@ -31,7 +31,7 @@ export const Language = {
   workspaces: "Workspaces",
   templates: "Templates",
   users: "Users",
-  audit: "Auditing",
+  audit: "Audit Logs",
   deployment: "Settings",
 };
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export const DeploymentDropdown: FC<DeploymentDropdownProps> = ({`
`52`	`52`	`/>`
`53`	`53`	`}`
`54`	`54`	`>`
`55`		`- Deployment`
	`55`	`+ Administration`
`56`	`56`	`</Button>`
`57`	`57`	`</PopoverTrigger>`
`58`	`58`
`@@ -128,7 +128,7 @@ const DeploymentDropdownContent: FC<DeploymentDropdownProps> = ({`
`128`	`128`	`css={styles.menuItem}`
`129`	`129`	`onClick={onPopoverClose}`
`130`	`130`	`>`
`131`		`- Auditing`
	`131`	`+ Audit Logs`
`132`	`132`	`</MenuItem>`
`133`	`133`	`)}`
`134`	`134`	`{canViewHealth && (`