add http client for in-memory gateway request dispatching #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR introduces an in-memory request dispatching mechanism for LocalStack, focusing on improved modularity and efficient request handling.
- Added
GatewayClientclass inclient.pyfor direct request injection into theGateway - Introduced
RuntimeContainerclass in newcomponents.pyfor centralized management of core runtime components - Simplified
serve_gatewayfunction inedge.pyto use pre-configured gateway fromcomponents.gateway - Modified S3 virtual host proxy handler in
virtual_host.pyto use the newGatewayClientfor request dispatching
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| self.gateway = gateway | ||
|
|
||
| def request(self, request: Request, server: str | None = None) -> Response: | ||
| from localstack.http.response import Response |
There was a problem hiding this comment.
style: This import should be at the top of the file with other imports
| """The Gateway processes incoming HTTP request and dispatches them to AWS services or internal resources""" | ||
|
|
||
| service_plugin_manager: "ServicePluginManager" | ||
| """The plugin manager """ |
There was a problem hiding this comment.
style: The docstring for service_plugin_manager is incomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
🚧 similar to localstack#7396, this adds an in-memory request dispatching mechanism. it has a similar but slightly different approach to organizing the runtime components into the container. just playing around.
Changes