Fix: Make secret value decoded for specific usecases #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR addresses a bug in LocalStack's Secrets Manager service, fixing the decoding of SecretBinary values to align with AWS behavior.
- Modified
localstack-core/localstack/services/secretsmanager/provider.pyto adddecode_secret_binary_from_responsefunction for conditional decoding - Updated
get_secret_valuemethod in the same file to use the new decoding function - Added new test case
test_get_secret_valueintests/aws/services/secretsmanager/test_secretsmanager.pyto verify correct encoding/decoding - Updated snapshot and validation files to include the new test case
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| @@ -1,10 +1,11 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| import base64 | |||
There was a problem hiding this comment.
style: Consider using from base64 import b64decode for a more specific import
|
|
||
| secret_arn = response["ARN"] | ||
|
|
||
| secret_value_response = aws_client.secretsmanager.get_secret_value(SecretId=secret_arn) |
There was a problem hiding this comment.
style: Consider using a constant or configuration value for the secret string instead of hardcoding 'footest'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With this PR I am trying to fix the bug mentioned on this issue : localstack#11319
Changes
Previously localstack assumed the behaviour of SecretBinary field is same for all the sdk request, but the behaviour differs. According to AWS docs:
So on this PR, I am adding a check to identify what entity is making the request, and localstack will decode the value if needed.
Testing