Skip to content

Conversation

salamaashoush
Copy link
Collaborator

Reverts #182

@joeskeen
Copy link
Contributor

@salamaashoush anything I can help with?

@salamaashoush
Copy link
Collaborator Author

There are some type-checking issues with the way we generate bindings now, I am preparing another PR to improve CI and use the hardcoded input/output for now

@salamaashoush
Copy link
Collaborator Author

@joeskeen I had to revert the generated bindings for now, since gridjs types are not the best and we got some ts type issues in the build, also signals needs a bit of refactoring so I also didn't include it, maybe we could use https://angular.io/guide/signal-inputs instead of manually updating it using effect, for now to publish a working and tested version I used the old implementation, thanks a lot for contributing the scripts, I will keep them until we figure a more reliable way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants