Skip to content

fix /angular circular dependencies #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix /angular circular dependencies #2962

merged 1 commit into from
Feb 25, 2025

Conversation

adumesny
Copy link
Member

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
fix /angular circular dependencies
cae38a1 
* fix gridstack#2955
* moves ng types into it's own plain file, fix order of include/export to reflect heirachy
Note: gridComp depends on gridItem but not other way around
@adumesny adumesny merged commit 663b439 into gridstack:master Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circular dependency between base-widget.ts and gridstack.component.ts
1 participant
@adumesny