Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index_column_diff: increase timeout for too_many_token's tests on Windows #2090

Merged

Conversation

otegami
Copy link
Contributor

@otegami otegami commented Nov 21, 2024

In CI, Test: HTTP: reference count: Apache Arrow: chunked step for Windows failed as follows.
These tests are unstable using the current timeout time.

...
--- (expected)
+++ (actual)
@@ -6,6 +6,5 @@
 [[0,0.0,0.0],true]
 column_create Deltas index COLUMN_INDEX|WITH_POSITION PostingLists deltas
 [[0,0.0,0.0],true]
-#|w| [ii][update][one] too many postings: <Deltas.index>: <1>(1): record:<PostingLists>(1:1), n-postings:<131072>, n-discarded-postings:<1>
 index_column_diff Deltas index
 [[0,0.0,0.0],[]]

===============================================================================
[2] index_column_diff/too_many_tokens
  int64_vector                                                56.2620s [failed]
===============================================================================
===============================================================================
...

So we will try to extend the timeout from 60 seconds to 120 seconds for these too_many_token's tests.

Copy link
Member

@komainu8 komainu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because CI for Windows passed.

@kou
Copy link
Member

kou commented Nov 21, 2024

安定するかなんかいかre-runしてみて。

@otegami otegami force-pushed the extend-the-timeout-about-index-column-diff-with-arrow branch 3 times, most recently from ae0f030 to e893640 Compare November 25, 2024 07:58
…dows

In CI, Test: HTTP: reference count: Apache Arrow: chunked step
for Windows failed as follows. This test isn't stable using
the current timeout time.

```
...
--- (expected)
+++ (actual)
@@ -6,6 +6,5 @@
 [[0,0.0,0.0],true]
 column_create Deltas index COLUMN_INDEX|WITH_POSITION PostingLists deltas
 [[0,0.0,0.0],true]
-#|w| [ii][update][one] too many postings: <Deltas.index>: <1>(1): record:<PostingLists>(1:1), n-postings:<131072>, n-discarded-postings:<1>
 index_column_diff Deltas index
 [[0,0.0,0.0],[]]

===============================================================================
[2] index_column_diff/too_many_tokens
  int64_vector                                                56.2620s [failed]
===============================================================================
===============================================================================
...
```

So we will try to extend the timeout from 60 seconds to 120 seconds
for these too_many_token's tests.
@otegami otegami force-pushed the extend-the-timeout-about-index-column-diff-with-arrow branch from e893640 to 546d111 Compare November 26, 2024 07:11
@otegami
Copy link
Contributor Author

otegami commented Nov 26, 2024

もう一度回してみて問題なさそうなら、PRをopenする。

@otegami
Copy link
Contributor Author

otegami commented Nov 27, 2024

The test for Windows looks stable.
Although only Ubuntu focal's tests are failed, we will fix them in the other PR #2105.

@otegami otegami marked this pull request as ready for review November 27, 2024 01:24
@kou kou merged commit 230a05d into groonga:main Nov 27, 2024
33 of 35 checks passed
@otegami otegami deleted the extend-the-timeout-about-index-column-diff-with-arrow branch November 27, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants