-
Notifications
You must be signed in to change notification settings - Fork 29
[AB Testing PoC] Add script to upload dictionaries #13861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jakeii
wants to merge
9
commits into
commercial/ab-testing-poc
Choose a base branch
from
jlk/ab-testing/fastly-api
base: commercial/ab-testing-poc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 959 kB ℹ️ View Unchanged
|
250b65c
to
02171b5
Compare
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
arelra
reviewed
May 1, 2025
arelra
reviewed
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds deploy script for
ab-testing
using the files output from the build step (not created yet).For both the
mvts
andab-tests
edge dictionaries, calculates a diff from the files and works out which operations (create/update/delete) need to be made to match the output from the config.Puts them together for use with the bulk update api.
There is an npm package for interacting with the API, however it didn't work perfectly with deno, specifically the tight security around allowing specific directory access and env vars.
Calling the API directly is very easy with
fetch
and there's only 2 endpoints anyway.This is not actually live, just getting the script ready.
Why?
So our ab test state can be uploaded to fastly.