implement football more button for when js is disabled #13903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +210 B (+0.02%) Total Size: 973 kB
ℹ️ View Unchanged
|
This was referenced May 2, 2025
SiAdcock
reviewed
May 8, 2025
| <div css={footballMatchesGridStyles}> | ||
| <div | ||
| <a |
There was a problem hiding this comment.
I think this is minor, raising out of interest. Nesting a button inside a link is not valid HTML:
Content model:
Transparent, but there must be no interactive content descendant, a element descendant, or descendant with the tabindex attribute specified.
There might be weird behaviour as a result.
An alternative solution might be to retain the outer <div> and only hide the <a> if JS loads. I haven't tested this.
<div>
{
jsLoaded ?
(<Button></Button>)
:
(<LinkButton></LinkButton>)
}
</div>There was a problem hiding this comment.
Thanks @SiAdcock for pointing this out and sharing the links. I made some changes and used a state jsEnabled which is set within a useEffect. Using that the component decides if it needs to use the link or the button. What do you think about this approach?
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
9a13902 to
0d4dc52
Compare
SiAdcock
reviewed
May 12, 2025
| useEffect(() => { | ||
| // This will only run after JS has loaded on the client | ||
| setJsLoaded(true); | ||
| }, []); |
There was a problem hiding this comment.
So sorry @marjisound, I've just noticed we have a useHydrated hook that does the same thing. Would you be able to use it here?
There was a problem hiding this comment.
Ah thanks for letting me know, just changed it to use the useHydrated hook
0d4dc52 to
6e1f9e8
Compare
JamieB-gu
reviewed
May 12, 2025
Comment on lines
235
to
236
| export const nextPageNoJsUrl = | ||
| 'https://www.theguardian.com/football/fixtures/more/2025/May/05'; |
There was a problem hiding this comment.
Aren't the routes with /more in the path being deprecated?
There was a problem hiding this comment.
Good point, I removed the more from the url
There was a problem hiding this comment.
👍 for these storybook tests!
Comment on lines
515
to
516
| onClick={(e) => { | ||
| e.preventDefault(); // prevent navigation when JS is enabled |
There was a problem hiding this comment.
If there's no link wrapping the button now is this still needed?
There was a problem hiding this comment.
You're right. I removed it 👍
- remove the preventDefault from button click handler - update the nextPageNoJsUrl value in fixtures Also fixing the bug where the parser was incorrectly using ajaxUrl as the for nextPageNoJsUrl.
SiAdcock
approved these changes
May 16, 2025
|
Seen on PROD (merged by @marjisound 9 minutes and 56 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change adds support for a fallback
Morebutton on the football matches pages for when JavaScript is disabled in the browser.Why introduce nextPageNoJsUrl:
There is a convention in frontend routing where for any page route (e.g. /football/fixtures/more/:year/:month/:day), there is also a corresponding .json route (e.g. /football/fixtures/more/:year/:month/:day.json). These .json routes return the full data required to render a page, including config and navigation.
In DCAR the
Morebutton is using the .json route to fetch more matches. However, this returns far more data than necessary — config, nav, and other unrelated information — when all that is needed is a list of matches to append to the current view.Upon further investigation, we noticed that the HTML version of the
/more/routes serves the same content as the equivalent non-/more/ routes. Based on this, we decided to remove the HTML versions of the /more/ routes to simplify routing. The PR for this: guardian/frontend#27939However, we later realised that the DCAR implementation did not support a non-JavaScript experience for the More button. To fix this, we needed a way to render the More button as a fallback link (i.e. an anchor tag) that simply navigates to the next page of matches when JavaScript is disabled.
Since the
/more/routes are being deprecated, we now use the equivalent non-/more/ route to construct that fallback link — this is provided via the newnextPageNoJsUrlprop.TOTO:
This PR can be merged after guardian/frontend#27946