Skip to content

HLS proxying and tuning #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

HLS proxying and tuning #668

merged 1 commit into from
Jul 29, 2020

Conversation

chudsaviet
Copy link
Contributor

  • Proxied HLS through HAProxy to avoid CORS issues and streamline web serving.
  • Made JPEG frames writing atomic.
  • Tuned HLS stream.

@guysoft
Copy link
Owner

guysoft commented Jul 26, 2020

@foosel opinions?

@chudsaviet
Copy link
Contributor Author

There is a PR to OctoPrint on review by @foosel - OctoPrint/OctoPrint#3647
Also I have created a OctoPi branch with Octoprint HLS support and HLS by default, for testing purposes - https://github.com/chudsaviet/OctoPi/tree/feature/devel_with_octoprint_hls .

@foosel
Copy link
Collaborator

foosel commented Jul 27, 2020

In principle fine. Haven't yet had a chance to look at the PR on my side though, RC stuff takes precedence.

@guysoft
Copy link
Owner

guysoft commented Jul 28, 2020

@chudsaviet Does this PR depend on the OctoPrint one?

@chudsaviet
Copy link
Contributor Author

No, it does not.

@guysoft
Copy link
Owner

guysoft commented Jul 29, 2020

Ok, then, seems nice, merging.

@guysoft guysoft merged commit 80744a2 into guysoft:devel Jul 29, 2020
@chudsaviet
Copy link
Contributor Author

Thank you!

@guysoft guysoft mentioned this pull request Nov 4, 2020
Closed
@guysoft guysoft mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chudsaviet @guysoft @foosel