Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (7287f4f) to head (0331630).
Report is 165 commits behind head on master.

@@           Coverage Diff           @@
##           master    #2449   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          16       16           
  Lines        2381     2381           
=======================================
  Hits         2132     2132           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Can we use #2444 instead?

sorry I didn't realize my PRs would conflict with yours.
#2444 is big enough that I don't fancy adding this patch there, but I'm okay with this one waiting for yours.

We provide our own global lock so I'm not surprised the tests pass.

Nice. So h5py is already and will remain thread safe under the new Python build ?

That is my 80% expectation but threads always find a way to surprise you (see #2019) and we do some fancy stuff with gc around nonlocal_close).

let's drop this for now: there's already a conflict now and by the time I circle back to it it'll be almost completely redundant.