Skip to content

Asyncio code hits error due to deprecated loop parameter #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
felixdivo opened this issue Apr 14, 2021 · 1 comment · Fixed by #1013
Closed

Asyncio code hits error due to deprecated loop parameter #1005

felixdivo opened this issue Apr 14, 2021 · 1 comment · Fixed by #1013
Labels
bug
Milestone
4.0.0 Release

Comments

@felixdivo
Copy link
Collaborator

The error can be seen here. Python 3.10 is still in alpha so there is not need for immediate action.

Is is valid to simply delete all custom handling of loops and replace it with asyncio.get_event_loop() wherever the loop is needed?
@felixdivo felixdivo added the bug label Apr 14, 2021
@felixdivo felixdivo added this to the 4.0 Release milestone Apr 14, 2021
@felixdivo felixdivo mentioned this issue Apr 14, 2021
Merged
@felixdivo
Copy link
Collaborator Author

The test was marked to be skipped in #940. Once fixed, the skipping should get removed.

@zariiii9003 zariiii9003 mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.0.0 Release
Development

Successfully merging a pull request may close this issue.

Deprecate loop argument zariiii9003/python-can
1 participant
@felixdivo