Skip to content

Deprecate loop argument #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

zariiii9003
Copy link
Collaborator

Fixes #1005

@mergify mergify bot requested a review from hardbyte April 15, 2021 20:55
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #1013 (42ffbbd) into develop (cd87d2d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1013      +/-   ##
===========================================
+ Coverage    70.55%   70.57%   +0.01%     
===========================================
  Files           76       76              
  Lines         7442     7450       +8     
===========================================
+ Hits          5251     5258       +7     
- Misses        2191     2192       +1     

@zariiii9003 zariiii9003 marked this pull request as draft April 15, 2021 21:40
@zariiii9003 zariiii9003 marked this pull request as ready for review April 15, 2021 21:59
@zariiii9003 zariiii9003 changed the title Decprecate loop argument Deprecate loop argument Apr 15, 2021
@hardbyte hardbyte merged commit fcb337d into hardbyte:develop Apr 15, 2021
@felixdivo felixdivo added this to the 4.0.0 Release milestone Apr 15, 2021
@zariiii9003 zariiii9003 deleted the loop_parameter_deprecation branch October 14, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asyncio code hits error due to deprecated loop parameter
3 participants