Disable error frames when ignore_rx_error_frames is set #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zariiii9003
reviewed
Feb 2, 2025
| @@ -702,6 +702,14 @@ def __init__( | |||
| ) | |||
| except OSError as error: | |||
| log.error("Could not enable error frames (%s)", error) | |||
| else: | |||
There was a problem hiding this comment.
You could simplify this a bit like this:
# set error frame filter
try:
self.socket.setsockopt(
constants.SOL_CAN_RAW,
constants.CAN_RAW_ERR_FILTER,
0x0 if ignore_rx_error_frames else 0x1FFFFFFF,
)
except OSError as error:
log.error("Could not enable error frame filter (%s)", error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
ignore_rx_error_framesfor socketcan interfaces has no effect since error filter is only applied whenignore_rx_error_framesis false