all: Adjust UseStateForUnknown plan modifiers to preserve known null state values
#1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvalle
commented
Jun 12, 2025
There was a problem hiding this comment.
The changes to this test and internal/fwserver/block_plan_modification_test.go were just to ensure the intended behavior was still tested, as the original tests did not actually set up the req.State value properly 😄
4d499e4 to
e772d51
Compare
austinvalle
added a commit
that referenced
this pull request
Jul 31, 2025
…l state values (#1161) * apply fix to string plan modifier and shared tests * sets * list * map * object * numbers, floats, and ints * bool * dynamics * add changelog
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1117
Description
This PR adjusts all of the
UseStateForUnknownplan modifiers to also preserve null state values (which are technically known). The original logic was excluding all null state values although we believe the intended behavior was to skip when creating resources (which should be checking the resource instance state for null, not the specific state value).Note
One of the impacts of fixing this bug would be any attributes in existing resource implementations that are relying on null values being set to unknown during update plans, which would now start to preserve the prior state (keeping null), so if the provider is not preserving those prior state values during apply, it could cause data consistency issues if that unknown marking was being relied on.
Off the top of my head, I'm not sure why you'd use
UseStateForUnknownin this way, since the goal of this plan modifier has always been to denote an attribute that doesn't change during apply on updates. Fixing this bug doesn't change that goal, it just makes it more precise.Rollback Plan
Changes to Security Controls
No