Skip to content

internal/fromproto: Introduce conversion functions for proto schemas to FW schemas #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2025
Merged

internal/fromproto: Introduce conversion functions for proto schemas to FW schemas #1200

merged 5 commits into from
Aug 11, 2025

Conversation

austinvalle
Copy link
Member

Related Issue

Ref: #1199

Description

Pulled out of #1199 as that PR isn't ready to be merged just yet and the logic contained within it will be useful for other Framework efforts 😄. This PR contains:

  • 3169aec Some lint adjustments I made to tests due to go vet now showing unnecessary nil checks in the Go language server
  • 1954b67 Refactoring of the dynamic type mapping that is now being used by the new schema converters
  • 73ede33 Schema converters to go from a protocol schema to a FW schema
  • 036b9da Some misc docs for actions that I feel like can merge now 👍🏻

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

No

@austinvalle austinvalle added types Issues and pull requests about our types abstraction and implementations. actions Tracking PRs and issues related to the TF actions work labels Aug 7, 2025
@austinvalle austinvalle requested a review from a team as a code owner August 7, 2025 20:58
@austinvalle austinvalle mentioned this pull request Aug 7, 2025
Draft
1 task
SBGoods
SBGoods approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@SBGoods SBGoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@austinvalle austinvalle merged commit ba065ff into main Aug 11, 2025
37 checks passed
@austinvalle austinvalle deleted the av/internal-schema-conversions branch August 11, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SBGoods SBGoods SBGoods approved these changes

Assignees
No one assigned
Labels
actions Tracking PRs and issues related to the TF actions work types Issues and pull requests about our types abstraction and implementations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinvalle @SBGoods