-
Notifications
You must be signed in to change notification settings - Fork 13
Add client capabilities into the validator request for write only #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
I will read and sign the CLA next week. In case somebody that is already having this signed can apply the changes, please, go ahead. |
Hi @yottta, thank you for the contribution! In addition to signing the CLA, can you also add a changelog entry for this PR marked as BUG FIXES? |
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
Signed-off-by: Andrei Ciobanu <andrei.ciobanu@opentofu.org>
I didn't forget about this. I am still waiting for some information before signing the CLA. Meanwhile, I wouldn't mind if anybody could merge the changes |
Fixes #282.
The PreferWriteOnlyAttribute validator is misconfigured in terms that the client capabilities received in the request are not given to the validator. Therefore, any call to validate will return no error rendering the validator useless.
This PR is passing over the client capabilities to the validator.