-
Notifications
You must be signed in to change notification settings - Fork 16
plannable import: support step.ConfigExact = [true|false]
for all config sources
#494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ConfigDirectory
With `step.ImportStateReadOnlyConfig` opt-out flag
b138a1c
to
2ef656a
Compare
cc: @austinvalle, I'd like to get your input on how this feels directionally, so we can decide whether to ship it in a release candidate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLDR, big fan of the approach/feedback if it works well for provider developers and think we should expand on it 👍🏻
ConfigDirectory
step.ConfigExact = [true|false]
for all config sources
I re-discovered #383 just now. |
Yes, #383 will be very useful for us. In the string-based |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no major qualms with the approach, just a thought on naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This PR extends
ImportState
auto-generated import blocks to work withstep.ConfigFile
andstep.ConfigDirectory
. It adds astep.ConfigExact
flag to opt out.cc: @gdavison