Skip to content

Conversation

bbasata
Copy link
Collaborator

@bbasata bbasata commented Apr 28, 2025

This PR extends ImportState auto-generated import blocks to work with step.ConfigFile and step.ConfigDirectory. It adds a step.ConfigExact flag to opt out.

cc: @gdavison

@bbasata bbasata requested a review from a team as a code owner April 28, 2025 13:18
@bbasata bbasata changed the title Flexible config directory plannable import: Write generated config to ConfigDirectory Apr 28, 2025
@bbasata bbasata force-pushed the flexible-config-directory branch from b138a1c to 2ef656a Compare May 2, 2025 11:27
@bbasata
Copy link
Collaborator Author

bbasata commented May 2, 2025

cc: @austinvalle, I'd like to get your input on how this feels directionally, so we can decide whether to ship it in a release candidate.

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR, big fan of the approach/feedback if it works well for provider developers and think we should expand on it 👍🏻

@bbasata bbasata requested a review from austinvalle May 2, 2025 20:35
@bbasata bbasata changed the title plannable import: Write generated config to ConfigDirectory plannable import: support step.ConfigExact = [true|false] for all config sources May 2, 2025
@bbasata
Copy link
Collaborator Author

bbasata commented May 2, 2025

TLDR, big fan of the approach/feedback if it works well for provider developers and think we should expand on it 👍🏻

I re-discovered #383 just now.

@gdavison
Copy link
Contributor

gdavison commented May 2, 2025

Yes, #383 will be very useful for us. In the string-based Config flow, we append, sometimes several levels deep, common configuration. Being able to add files or merge directories would simplify the use of ConfigDirecotory

@bbasata bbasata requested review from austinvalle and removed request for austinvalle May 6, 2025 18:14
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no major qualms with the approach, just a thought on naming

@bbasata bbasata requested a review from austinvalle May 7, 2025 16:19
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@austinvalle austinvalle added this to the v1.13.0 milestone May 7, 2025
@bbasata bbasata merged commit a72064c into main May 7, 2025
40 checks passed
@bbasata bbasata deleted the flexible-config-directory branch May 7, 2025 22:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants