Update vscode-languageclient and enable proposed features #150
Conversation
|
Forgot to mention that some of the dependencies were updated through |
package.json
Outdated
| "lru-cache": "^4.1.3", | ||
| "request": "^2.86.0", | ||
| "request-promise-native": "^1.0.5", | ||
| "vscode-languageclient": "^4.4.0" | ||
| "vscode-languageclient": "5.3.0-next.4" |
There was a problem hiding this comment.
This looks like an "under development" version?
There was a problem hiding this comment.
Yes, I'm not sure when it is planned on being released. This PR is not blocking anything though so we can wait until there is a stable release
There was a problem hiding this comment.
I would hate to break things for users out there.
|
@bubba I am pretty sure this should be fixable now, given vscode 1.35.0 is now out. |
|
And according to https://www.npmjs.com/package/vscode-languageclient, current version is 5.2.1 |
…nto window-progress
|
@alanz conflicts resolved! |
| @@ -245,7 +245,7 @@ | |||
| "lru-cache": "^4.1.3", | |||
| "request": "^2.86.0", | |||
| "request-promise-native": "^1.0.5", | |||
| "vscode-languageclient": "^4.4.0", | |||
| "vscode-languageclient": "5.3.0-next.5", | |||
There was a problem hiding this comment.
Doesn't the next suffix mean you have to be on the dev channel for vscode?
There was a problem hiding this comment.
No, the vscode version is constrained from the engines.vscode field from what I can tell: I tried bumping it to 1.35 today and I got an error when installing it with my older version of vscode. vscode-languageclient is just the library for connecting vscode extension APIs to LSP
|
@bubba I think the vscode-languageclient needs to be 5.2.1 |
|
The progress APIs/plugs are only in 5.3.x microsoft/vscode-languageserver-node@dbe6494 |
|
@alanz is this good to go? |
|
@bubba yes, will do a release today some time |
No description provided.