New Style: Gradient Light #2616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase this onto the current master branch instead of your very old fork. |
done and sorry! I'm still new to this |
joshgoebel
reviewed
Jun 23, 2020
joshgoebel
reviewed
Jun 23, 2020
joshgoebel
reviewed
Jun 23, 2020
|
No need for apology. Better, but this still has a bunch of extra cruft. All this should include:
|
|
I did a hard reset and added the file again |
and theme to changelog and footnote (forgot). Thank you! |
If you plan to contribute more in the future it's probably easier to never let your master get off our master and instead make a new branch anytime you want to make a PR. :-) This is much cleaner, thanks! |
joshgoebel
reviewed
Jun 28, 2020
joshgoebel
approved these changes
Jun 28, 2020
|
@samiaab1990 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Wanted to add a new style: Gradient Light