fix(tooling) developer.html does not render highlighted language properly #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, that was a bad mistake on my part. :-/ You fix isn't bad at all, but I'm sure there is a way to move that into a single method and then just call it from both... I'll see. |
|
@egor-rogov Back to you. :-) If that looks good I will merge. |
|
Yes, that's good, thanks! |
joshgoebel
approved these changes
Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
developer.htmltool correctly shows markup using specified language, but always displays rendering in autodetection mode.To reproduce, enter e. g.
and choose Language: bash. The code is (erroneously) rendered for
nginx, while markup is (correctly) forbash.I'm not familiar with vue and somehow managed to fix the issue although in a disgusting way. There should be a better solution for sure.