Add Flock notification platform #14533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| payload = {'text': message} | ||
|
|
||
| _LOGGER.debug("Attempting to call Flock at %s", self._url) | ||
| session = async_get_clientsession(self._hass) |
There was a problem hiding this comment.
I think it's better to do this once in get_service and pass the session and the loop instead of hass to the service instance.
| self._hass = hass | ||
| self._url = url | ||
|
|
||
| @asyncio.coroutine |
There was a problem hiding this comment.
Use Python 3.5 async syntax, async def.
|
|
||
| try: | ||
| with async_timeout.timeout(10, loop=self._hass.loop): | ||
| response = yield from session.post(self._url, json=payload) |
PhilRW
pushed a commit
to PhilRW/home-assistant
that referenced
this pull request
Jun 1, 2018
* Add Flock notification platform * Use async syntax and move session and loop
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Add Flock notification platform * Use async syntax and move session and loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for sending notifications from home Assistant to Flock.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5395
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
.coveragerc.