Add number platform for LED brightness to air-Q
#145385
Closed
+282
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Closed
8 tasks
7010337 to
311af0b
Compare
joostlek
requested changes
May 21, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
57203d9 to
bb21fa0
Compare
joostlek
requested changes
May 30, 2025
bb21fa0 to
4fc0501
Compare
|
this PR is currently waiting for #146169 |
4fc0501 to
f69d299
Compare
|
I believe, I addressed every comment, @joostlek. |
353f466 to
b703a52
Compare
joostlek
requested changes
Jun 20, 2025
number platform for LED brightnessnumber platform for LED brightness to air-Q
7229533 to
43a71f7
Compare
43a71f7 to
df7c9d4
Compare
joostlek
requested changes
Jul 23, 2025
I had added this `usefixtures("mock_setup_entry")` by accident
Instead of explicitly patching calls to `aioairq.AirQ` methods, patch out the whole class, as imported either in the coordinator or the config flow, some of its most used methods with sensible defaults, and then only modify the mocks when necessary
Instead of explicitly patching each method, create a fixture that patches the whole class with an AsyncMock and some meaningful defaults for most used methods. Then patch only where and when needed
Brightness is fetched by `AirQCoordinator` in `_async_update_data` and is expressed in %
This was referenced Jul 30, 2025
Merged
df7c9d4 to
85de44d
Compare
joostlek
reviewed
Aug 12, 2025
Comment on lines
+26
to
+41
| async def setup_platform(hass: HomeAssistant) -> None: | ||
| """Load AirQ integration. | ||
| This function does not patch AirQ itself, rather it depends on being | ||
| run in presence of `mock_coordinator_airq` fixture, which patches calls | ||
| by `AirQCoordinator.airq`, which are done under `async_setup`. | ||
| """ | ||
| config_entry = MockConfigEntry( | ||
| domain=DOMAIN, data=TEST_USER_DATA, unique_id=TEST_DEVICE_INFO["id"] | ||
| ) | ||
| config_entry.add_to_hass(hass) | ||
|
|
||
| # The patching is now handled by the mock_coorinator_airq fixture. | ||
| # We just need to load the component. | ||
| assert await hass.config_entries.async_setup(config_entry.entry_id) | ||
| await hass.async_block_till_done() |
There was a problem hiding this comment.
This is something for __init__.py
Comment on lines
+11
to
+23
| TEST_USER_DATA = { | ||
| CONF_IP_ADDRESS: "192.168.0.0", | ||
| CONF_PASSWORD: "password", | ||
| } | ||
| TEST_DEVICE_INFO = DeviceInfo( | ||
| id="id", | ||
| name="name", | ||
| model="model", | ||
| sw_version="sw", | ||
| hw_version="hw", | ||
| ) | ||
| TEST_DEVICE_DATA = {"co2": 500.0, "Status": "OK"} | ||
| TEST_BRIGHTNESS = 42 |
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
|
closing this because I somehow botched the history of the remote branch from which the PR is open, will open a new one, sorry for proliferating them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Each air-Q device is equipped with 2 LED strips that function as LED level indicators / bar graphs for two (configurable) sensors. This PR exposes a single
numberentity for eachairqdevice, allowing to set the brightness of both strips simultaneously.This is the changes to the backend
aioairqpackage that permit such brightness control.Type of change
Additional information
numberplatform forairqintegration home-assistant.io#39129Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: