Add device conditions to miele #149910
Add device conditions to miele #149910
Conversation
| "rinse_hold": "{entity_name} is in rinse hold", | ||
| "in_use": "{entity_name} is in use", | ||
| "service": "{entity_name} is in service", | ||
| "supercooling": "{entity_name} Supercooling is active", |
There was a problem hiding this comment.
| "supercooling": "{entity_name} Supercooling is active", | |
| "supercooling": "{entity_name} supercooling is active", |
| "in_use": "{entity_name} is in use", | ||
| "service": "{entity_name} is in service", | ||
| "supercooling": "{entity_name} Supercooling is active", | ||
| "supercooling_superfreezing": "{entity_name} Supercooling/superfreezing is active", |
There was a problem hiding this comment.
| "supercooling_superfreezing": "{entity_name} Supercooling/superfreezing is active", | |
| "supercooling_superfreezing": "{entity_name} supercooling/superfreezing is active", |
| "program_interrupted": "{entity_name} has interrupted program", | ||
| "programmed": "{entity_name} is programmed", | ||
| "rinse_hold": "{entity_name} is in rinse hold", | ||
| "in_use": "{entity_name} is in use", |
There was a problem hiding this comment.
Is the difference between "in service" and "in use" obvious?
There was a problem hiding this comment.
This should probably be "under service" below, like "under maintenance".
There was a problem hiding this comment.
I have tried to follow the wording and spellings from Miele when reasonable. We can end up with a mess if we "improve" too much. At least the user will recognise the terms from their appliance, manuals and other sources (though Miele designers and authors are not consequent)
I suggest that we stay with the suggested terms. Changing them here also means that we must change in entity names, states etc.
Regarding "service" and "in use" the difference may not be obvious but the states are what they are. They are reportded this way from the API.
There was a problem hiding this comment.
The issue here is that the keys are in use and service.
As I understand it the latter one stands for maintenance?
In that case translating it as "in service" changes the meaning to more or less the opposite.
There was a problem hiding this comment.
There is no guidance from Miele what "service" means in this context. Could be "in service", "under maintenance", "requires service", or something else. Let us use "in service state" here and await response from the user community.
| "service": "{entity_name} is in service", | ||
| "supercooling": "{entity_name} Supercooling is active", | ||
| "supercooling_superfreezing": "{entity_name} Supercooling/superfreezing is active", | ||
| "superfreezing": "{entity_name} Superfreezing is active", |
There was a problem hiding this comment.
| "superfreezing": "{entity_name} Superfreezing is active", | |
| "superfreezing": "{entity_name} superfreezing is active", |
| "supercooling": "{entity_name} Supercooling is active", | ||
| "supercooling_superfreezing": "{entity_name} Supercooling/superfreezing is active", | ||
| "superfreezing": "{entity_name} Superfreezing is active", | ||
| "superheating": "{entity_name} Superheating is active", |
There was a problem hiding this comment.
| "superheating": "{entity_name} Superheating is active", | |
| "superheating": "{entity_name} superheating is active", |
There was a problem hiding this comment.
I am not a native speaker but for me it looked like as if it should not be capitalized b/c it's in the sentence, or?
There was a problem hiding this comment.
Those are all feature names therefore the capitalization is correct.
But Miele seems to use "SuperCool" and "SuperFreeze" in their UI:
https://shop.miele.com.au/en/kitchen/refrigeration/
https://www.mieleusa.com/c/rumored-for-a-reason-mastercool-refrigerators-7026.htm
https://www.mieleusa.com/c/high-end-refrigerators-3291.htm
There was a problem hiding this comment.
As mentioned above Miele are not consequent. All these variants can be found:
- Supercool
- SuperCool
- Supecooling
- SUPERCOOLING
- and more...
The switch entity and state are named Supercooling. I suggest that we stay with the same name in all contexts in this integration.
There was a problem hiding this comment.
For the German translation I see "SuperCool" and "SuperFrost" used by Miele, so they could not decide to stick to either English or partly translate into German either.
Just for clarification: "Superheating" is used for what device classes?
There was a problem hiding this comment.
I cannot remember that I have seen Superheating in use. I got the code map from Miele a couple of years ago and I just entered it when I created the custom component once upon a time.
Proposed change
Add device automations - conditions to miele integration.
The status sensor, for example sensor.washing_machine is exposed as a device_condition.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: