Skip to content

Add humidity (steamer) control to Huum #150330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 10, 2025
Merged

Add humidity (steamer) control to Huum #150330

merged 6 commits into from
Aug 10, 2025

Conversation

vincentwolsink
Copy link
Contributor

@vincentwolsink vincentwolsink commented Aug 9, 2025 •
edited
Loading

Proposed change

Implement humidity control for Huum.

I cannot implement it as a "humidifier" because it actually sets the steamer duty cycle from 0-10. There is no humidity measuring or target humidity percentage to be set. I could call it "Steamer" since it controls the steamer, but the vendor app named the control "Humidity" so I figured its better to stick with that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 9, 2025

Hey there @frwickst, mind taking a look at this pull request as it has been labeled with an integration (huum) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of huum can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign huum Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@vincentwolsink vincentwolsink mentioned this pull request Aug 9, 2025
Merged
8 tasks
@joostlek
Copy link
Member

joostlek commented Aug 9, 2025

Oh btw, mind sharing your discord username or sending me a message so we can add you to the codeowner channels?

NoRi2909
NoRi2909 reviewed Aug 9, 2025
View reviewed changes
@vincentwolsink @NoRi2909
Update homeassistant/components/huum/strings.json
a61fa2d 
Co-authored-by: Norbert Rittel <norbert@rittel.de>
joostlek
joostlek requested changes Aug 10, 2025
View reviewed changes
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 10, 2025 07:54
@vincentwolsink vincentwolsink marked this pull request as ready for review August 10, 2025 18:19
@home-assistant home-assistant bot requested a review from joostlek August 10, 2025 18:19
joostlek
joostlek reviewed Aug 10, 2025
View reviewed changes
joostlek
joostlek reviewed Aug 10, 2025
View reviewed changes
joostlek
joostlek reviewed Aug 10, 2025
View reviewed changes
@joostlek joostlek merged commit c2b284d into home-assistant:dev Aug 10, 2025
30 checks passed
@joostlek
Copy link
Member

Oh btw, mind sharing your discord username or sending me a message so we can add you to the codeowner channels?

This one still stands btw :)

@vincentwolsink
Copy link
Contributor Author

vincentwolsink commented Aug 10, 2025 •
edited
Loading

Oh btw, mind sharing your discord username or sending me a message so we can add you to the codeowner channels?

This one still stands btw :)

I’ve sent you a message yesterday evening 🙂

@vincentwolsink vincentwolsink deleted the huum_humidity branch August 10, 2025 20:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@NoRi2909 NoRi2909 NoRi2909 left review comments

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: huum new-feature new-platform Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentwolsink @joostlek @NoRi2909