Also test unique ID in config flow test for APCUPSD #150362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the APCUPSD integration's test coverage by adding a unique ID verification in the config flow test. The change improves test quality by ensuring the config flow correctly sets the unique ID based on the device's serial number.
- Adds assertion to verify unique ID is properly set during config flow
- Updates quality scale documentation to reflect completed test requirement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/components/apcupsd/test_config_flow.py | Adds unique ID assertion to verify config flow sets unique_id to device serial number |
| homeassistant/components/apcupsd/quality_scale.yaml | Removes TODO comment about testing unique ID since it's now implemented |
zweckj
approved these changes
Aug 10, 2025
Nippey
pushed a commit
to Nippey/home-assistant
that referenced
this pull request
Aug 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds an additional check for unique ID in config flow tests for APCUPSD.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: