Skip to content

Introduce target_temperature_state_address for climate device #21541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

Introduce target_temperature_state_address for climate device #21541

merged 1 commit into from
Mar 7, 2019

Conversation

marvin-w
Copy link
Contributor

@marvin-w marvin-w commented Feb 28, 2019 •
edited by dgomes
Loading

Description:

breaking change: users will need to update their configuration and change target_temperature_address to target_temperature_state_address.

Update xknx to version 0.10.0 which contains the following fixes and features:

  • (breaking change) Introduce target_temperature_state_address for climate devices (fixes KNX climate - target_temperature_address is used for reading AND writing #20106), users will need to update their configuration after this release and change target_temperature_address to target_temperature_state_address.
  • Connection config can now be configured in xknx.yml.
  • Introduce a configurable rate limit which limits the number of KNX telegrams sent to the bus per second.
  • Users who configured their lights via xknx.yml no longer need to manually set min_kelvin and max_kelvin (fixes KNX - light.py issue #21251)

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8785

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Feb 28, 2019
@marvin-w marvin-w mentioned this pull request Feb 28, 2019
Merged
2 tasks
@marvin-w marvin-w changed the title Update xknx to version 0.10.0 (breaking change) update xknx to version 0.10.0 Feb 28, 2019
@marvin-w marvin-w changed the title (breaking change) update xknx to version 0.10.0 Update xknx to version 0.10.0 Feb 28, 2019
Julius2342
Julius2342 reviewed Mar 1, 2019
View reviewed changes
dgomes
dgomes reviewed Mar 7, 2019
View reviewed changes
@dgomes
Copy link
Contributor

dgomes commented Mar 7, 2019 •
edited
Loading

If I understand properly this is a breaking change ?

The old behavior will break ?

@marvin-w
Copy link
Contributor Author

marvin-w commented Mar 7, 2019

Yes. That's exactly why the label "breaking-change" was added.

From the description:

breaking change) Introduce target_temperature_state_address for climate devices (fixes #20106), users will need to update their configuration after this release and change target_temperature_address to target_temperature_state_address.

@dgomes
Copy link
Contributor

dgomes commented Mar 7, 2019 •
edited
Loading

You should then update PR description and write a clear paragraph that will be used in the release blog post (this is a paragraph for users, not for devs)

@marvin-w
Copy link
Contributor Author

marvin-w commented Mar 7, 2019

It's already there. Just use the 4 list items in the description as changelog

@dgomes
Copy link
Contributor

dgomes commented Mar 7, 2019 •
edited
Loading

We will not use all those lines in the breaking changes section of the release...
I don't know knx, but this is the paragraph I would expect (not the current bullets, those are for devs):

breaking change: users will need to update their configuration and change target_temperature_address to target_temperature_state_address.

Is this enough for a normal user to read/fix ?

@marvin-w
Copy link
Contributor Author

marvin-w commented Mar 7, 2019

Ah so you mean only for breaking change, then yes, that paragraph would be enough for users to know what to change

@dgomes
Copy link
Contributor

dgomes commented Mar 7, 2019

I copied my sentence into the description, but can you update the title ? The current one is not very descriptive on the impact of the version change...

@marvin-w marvin-w changed the title Update xknx to version 0.10.0 Introduce target_temperature_state_address for climate device Mar 7, 2019
@marvin-w marvin-w changed the title Introduce target_temperature_state_address for climate device (breaking change) Introduce target_temperature_state_address for climate device Mar 7, 2019
@marvin-w
Copy link
Contributor Author

marvin-w commented Mar 7, 2019

I updated the title

@dgomes dgomes changed the title (breaking change) Introduce target_temperature_state_address for climate device Introduce target_temperature_state_address for climate device Mar 7, 2019
@dgomes dgomes merged commit 5112f8f into home-assistant:dev Mar 7, 2019
@ghost ghost removed the in progress label Mar 7, 2019
This was referenced Mar 9, 2019
Closed
Merged
@balloob balloob mentioned this pull request Mar 20, 2019
Merged
@farmio farmio mentioned this pull request Jul 18, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgomes dgomes dgomes approved these changes

@Julius2342 Julius2342 Julius2342 approved these changes

Assignees
No one assigned
Labels
breaking-change cla-signed integration: knx small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KNX - light.py issue KNX climate - target_temperature_address is used for reading AND writing
5 participants
@marvin-w @dgomes @Julius2342 @cgarwood @homeassistant