Skip to content

Add custom holidays to workday sensor #21718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 10, 2019
Merged

Add custom holidays to workday sensor #21718

merged 10 commits into from
Mar 10, 2019

Conversation

epleypa
Copy link
Contributor

@epleypa epleypa commented Mar 6, 2019 •
edited
Loading

Description:

Add custom holidays to workday sensor (such as company, personal holidays, or vacations)

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8887

Example entry for configuration.yaml (if applicable):

binary_sensor:
- platform: workday
  country: US
  workdays: [mon,tue,wed,thu,fri]
  excludes: [sat,sun,holiday]
  add_holidays: ['2018-12-26','2018-12-27','2018-12-28','2018-12-31']

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@ghost ghost added the in progress label Mar 6, 2019
houndci-bot
houndci-bot reviewed Mar 6, 2019
View reviewed changes
houndci-bot
houndci-bot reviewed Mar 6, 2019
View reviewed changes
houndci-bot
houndci-bot reviewed Mar 9, 2019
View reviewed changes
fabaff
fabaff requested changes Mar 9, 2019
View reviewed changes
houndci-bot
houndci-bot reviewed Mar 9, 2019
View reviewed changes
This was referenced Mar 9, 2019
Closed
Merged
@ghost ghost assigned fabaff Mar 10, 2019
@fabaff fabaff merged commit c888e65 into home-assistant:dev Mar 10, 2019
@ghost ghost removed the in progress label Mar 10, 2019
@balloob balloob mentioned this pull request Mar 20, 2019
Merged
@epleypa epleypa deleted the patch-1 branch October 3, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@fabaff fabaff fabaff approved these changes

Assignees

@fabaff fabaff

Labels
cla-signed integration: workday small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epleypa @fabaff @houndci-bot @homeassistant