-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Deprecate http.api_password #21884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deprecate http.api_password #21884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
GitHub Drafted PR would trigger CI after changed it to normal PR. I have to commit a comment change to trigger it
3d4323a
to
a061f07
Compare
balloob
reviewed
Mar 10, 2019
@@ -407,7 +407,7 @@ def get_template(self, latest): | |||
}) | |||
|
|||
no_auth = '1' | |||
if hass.config.api.api_password and not request[KEY_AUTHENTICATED]: | |||
if not request[KEY_AUTHENTICATED]: | |||
# do not try to auto connect on load | |||
no_auth = '0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a future PR, this is no longer used.
balloob
reviewed
Mar 10, 2019
balloob
reviewed
Mar 10, 2019
balloob
reviewed
Mar 10, 2019
balloob
reviewed
Mar 10, 2019
balloob
approved these changes
Mar 11, 2019
19 tasks
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
http.api_password
config is deprecated, please add legacy_api_password auth provider if you still want to use api_password as authentication.For example, if you have following configuration in previous release
You will get invalid configuration error in 0.90, because
api_password
config is required options forlegacy_api_password
auth provider now. You need to change your configuration.yaml toHowever, if you don't have
auth_providers
under yourhomeassistant
configuration section, for exampleWe will give your more time to migrate your configuration, your HA system can still start up, we will load a legacy_api_password auth provider with api_password for you. However, you will receive a warning message to remind you change to the new configuration.
Please note, api_password authentication will eventually be removed, we advise user change to use one of other authentication methods.
Description:
This PR is one more step towards our goal to remove api_password entirely. Now, api_password no long lives in http component, all logic moved to legacy_api_password auth provider.
This PR does not change the way we do authentication, use api_password in query or header is still valid method, but we will print out INFO level log to remind user move away from those method. I am planning increase them to WARN level maybe in 0.91 release.
Detail changes
http.api_password
hass.confg.api.api_password
password
from hassio/homeassistant/options
command's payloadAuthManager
helper functionsRelated issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8894
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: