Changed from nanoleaf_aurora to nanoleaf #21913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nanoleaf component now supports both nanoleaf lights, Aurora and Canvas
Changed the dependency to
pynanoleaf
(disclaimer: I am currently the maintainer of this dependency and it is quite new),nanoleaf
does not seem to be maintained anymore. Thenanoleaf
module does not support Canvas unfortunatelyNote that this is a BREAKING change from configuration for
nanoleaf_aurora
tonanoleaf
If you have any pointer as to how to make this easier for users (maybe accept both, nanoleaf_aurora and nanoleaf?) please do tell!
Description:
Related issue (if applicable): None
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8906
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: