Skip to content

Add device tracking support for the Arris TG2492LG router #30972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 16, 2020
Merged

Add device tracking support for the Arris TG2492LG router #30972

merged 7 commits into from
Apr 16, 2020

Conversation

vanbalken
Copy link
Contributor

@vanbalken vanbalken commented Jan 19, 2020 •
edited
Loading

Description:

This pull requests adds support for tracking devices using the Arris TG2492LG router. This is one of the routers provided by Ziggo, a cable operator in the Netherlands, to their customers as the Ziggo Connectbox.

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#11807

Example entry for configuration.yaml:

# Example configuration.yaml entry
device_tracker:
  - platform: arris_tg2492lg
    host: YOUR_ROUTER_IP
    password: YOUR_ADMIN_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@vanbalken vanbalken changed the title Feature/add arris tg2492lg support Add device tracking support for the Arris TG2492LG router Jan 19, 2020
@vanbalken vanbalken mentioned this pull request Jan 19, 2020
Merged
2 tasks
@stale
Copy link

stale bot commented Mar 21, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Mar 21, 2020
@stale stale bot removed the stale label Mar 22, 2020
@vanbalken
Copy link
Contributor Author

How can I get someone to look at this PR? :)

frenck
frenck reviewed Mar 22, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 small comments, to me it looks good. However, I'm not highly familiar with device trackers. So another reviewer needs to take a look.

Don't worry about the stale bot, in this case you where awaiting our review and we will pick it up in those cases (just like I do now).

frenck
frenck reviewed Mar 22, 2020
View reviewed changes
@vanbalken @frenck
Use f-strings
fb180ba 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@frenck
Copy link
Member

frenck commented Mar 23, 2020

✅ Looks good to me! However, needs a second reviewer to verify.

MartinHjelmare
MartinHjelmare requested changes Apr 16, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of clean ups.

MartinHjelmare
MartinHjelmare reviewed Apr 16, 2020
View reviewed changes
MartinHjelmare
MartinHjelmare approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

@springstan springstan merged commit 3d9ae1b into home-assistant:dev Apr 16, 2020
@phillprice
Copy link

phillprice commented Apr 16, 2020 •
edited
Loading

Worth noting this is a Virgin Media Hub 3 in the UK, just tested this commit locally and it works well. Thank you <3

@vanbalken vanbalken deleted the feature/add-arris-tg2492lg-support branch April 17, 2020 07:52
@lock lock bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: arris_tg2492lg new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vanbalken @frenck @phillprice @MartinHjelmare @homeassistant @springstan