Add transition support to scenes, cleanup blocking parameter #34434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
Apr 20, 2020
|
Moving PR back to draft. As discussed today, this needs some tuning to be more future proof. |
8 tasks
|
Converted it to use This allows us to easily add new reproduce/scene options in the future. Added a link to the documentation PR as well. |
balloob
approved these changes
Apr 21, 2020
| @@ -63,7 +65,7 @@ def __init__(self, config, address_connection): | |||
| async def async_added_to_hass(self): | |||
| """Run when entity about to be added to hass.""" | |||
|
|
|||
| async def async_activate(self): | |||
| def activate(self, **kwargs: Any) -> None: | |||
There was a problem hiding this comment.
The pypck library supports asyncio via asyncio transports and protocols. This should run in the event loop.
There was a problem hiding this comment.
def send_command(self, pck):
self.loop.create_task(self.send_command_async(pck))It is indeed deeper into the pypck library. Thanks @MartinHjelmare 👍
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds transition support to the
scene.turn_onandscene.applyservices.Furthermore:
blockingmethod parameter fromasync_reproduce_statein our state helpers.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: