-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Frontier silicon #5750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontier silicon #5750
Conversation
#5662) Add an optional extended description…
* Bugfix sonos group coordinator * Fix tests
* Fix for missing netatmo tags in 0.37 Also fix issue with SSL certificate for vpn_url Signed-off-by: Hugo D. (jabesq) <jabesq@gmail.com> * Netatmo welcome: vpn_url can be empty Signed-off-by: Hugo D. (jabesq) <jabesq@gmail.com> * add config floag to disable SSL verification for vpn_url Signed-off-by: Hugo D. (jabesq) <jabesq@gmail.com> * Import CONF_VERIFY_SSL from const
* Fix bug for UNREACH devices / Variable handling and update. * fix track_time * update after data after creation * add message output * change unreach * change unreach code * Revert "change unreach code" This reverts commit f58430d. * update pyhomematic
* Bugfix state * remove debug
* Prevent events about MQTT messages received to cause infinite loop when two HA instances are crossconfigured for mqtt_eventstream. * Fix linting * Publish all MQTT received events except incoming from eventstream. Also make it configurable.
@zhelev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @scarface-4711 to be potential reviewers. |
try: | ||
if host and port and password: | ||
yield from async_add_entities( | ||
[FrontierSiliconDevice(DEVICE_URL.format(host, port), password)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (81 > 79 characters)
# pylint: disable=unused-argument | ||
# def setup_platform(hass, config, add_devices, discovery_info=None): | ||
@asyncio.coroutine | ||
def async_setup_platform(hass, config, async_add_entities, discovery_info=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (80 > 79 characters)
I need some help here (my first python project) - the travis requirements check won't pass. |
@balloob I am pretty new here and it is my first python project. Can you give me a hint what do you mean with removing the 'checklist'? So far I just followed the tips from the other guys and updated my branch. |
self.assertRaises(requests.exceptions.MissingSchema, fsapi.update) | ||
|
||
self.assertTrue(True) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line at end of file
"""Test that a host with a valid url is set when using a conf.""" | ||
import requests | ||
|
||
fsapi = FSAPIDevice('INVALID_URL','1234') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing whitespace after ','
|
||
self.assertTrue(result) | ||
|
||
def test_invalid_host(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
result = frontier_silicon.setup_platform(self.hass, fake_config, mock.MagicMock()) | ||
|
||
#fsapi = FSAPIDevice('DSDSDS','32332322') | ||
#fsapi.update() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block comment should start with '# '
} | ||
result = frontier_silicon.setup_platform(self.hass, fake_config, mock.MagicMock()) | ||
|
||
#fsapi = FSAPIDevice('DSDSDS','32332322') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block comment should start with '# '
fake_config = { | ||
const.CONF_HOST: 'host_ip', | ||
} | ||
result = frontier_silicon.setup_platform(self.hass, fake_config, mock.MagicMock()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (90 > 79 characters)
I guess I've reached a dead end here, closing the PR and will retry, will revisit all steps and hope this time it works out |
Description:
new component - frontier silicon, 'depends on latest' netdisco
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#1966
Example entry for
configuration.yaml
(if applicable):