Notify ciscospark #6130
Merged
Notify ciscospark #6130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shenning00, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @rmkraus to be potential reviewers. |
houndci-bot
reviewed
Feb 20, 2017
| title = kwargs.get(ATTR_TITLE) + ": " | ||
| self._spark.messages.create(roomId=self._default_room, text=title + message) | ||
| except SparkApiError as api_error: | ||
| _LOGGER.error("Could not send CiscoSpark notification. Error: %s", api_error) |
There was a problem hiding this comment.
line too long (89 > 79 characters)
| title = "" | ||
| if kwargs.get(ATTR_TITLE) is not None: | ||
| title = kwargs.get(ATTR_TITLE) + ": " | ||
| self._spark.messages.create(roomId=self._default_room, text=title + message) |
There was a problem hiding this comment.
line too long (88 > 79 characters)
| config.get(CONF_TOKEN), | ||
| config.get(CONF_ROOMID)) | ||
|
|
||
| class CiscoSparkNotificationService(BaseNotificationService): |
| }) | ||
|
|
||
| # pylint: disable=unused-variable | ||
| def get_service(hass, config, discovery_info=None): |
houndci-bot
reviewed
Feb 20, 2017
| self._spark.messages.create(roomId=self._default_room, | ||
| text=title + message) | ||
| except SparkApiError as api_error: | ||
| _LOGGER.error("Could not send CiscoSpark notification. Error: %s", |
| title = "" | ||
| if kwargs.get(ATTR_TITLE) is not None: | ||
| title = kwargs.get(ATTR_TITLE) + ": " | ||
| self._spark.messages.create(roomId=self._default_room, |
| def send_message(self, message="", **kwargs): | ||
| """ | ||
| Send a message to a user. | ||
|
|
| self._spark = CiscoSparkAPI(access_token=self._token) | ||
|
|
||
|
|
||
| def send_message(self, message="", **kwargs): |
| Initialize the service. | ||
|
|
||
| Args: | ||
| token: Cisco Spark Developer's Token |
| def __init__(self, token, default_room): | ||
| """ | ||
| Initialize the service. | ||
|
|
|
I will now start on the PR for the documentation. |
|
I added documentation but could not verify it locally. |
|
Looks great 🐬 thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a new notifier for Cisco Spark
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2104
I couldn't verify the documentation.
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
Working on it.
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass