Skip to content

Updated Lutron Caseta component to support additional shade types (Triathlon and Sivoia QS Wireless) #9302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

upsert
Copy link
Contributor

@upsert upsert commented Sep 4, 2017

Description:

Updated Lutron Caseta component to support additional shade types (Triathlon and Sivoia QS Wireless).

As suggested in the closed Pull Request #8903, the upstream pylutron-caseta library has been updated to support getting devices by their domain such as 'light', 'switch' and 'cover'. This avoids having to update Home Assistant to add new device support and pushes the responsibility to the third-party library.

Upstream library pylutron-caseta 0.2.8 is now available and supports this new function.

In addition:

  • Removed all references to 'Serena' shades since multiple types are now supported.
  • As suggested by pylint, modified functions in cover/lutron_caseta.py to match the functions they are overriding.
  • Updated lutron_caseta.py and requirements_all.txt with new pylutron-caseta 0.2.8 dependency.
  • Minor update to single quotes in cover/lutron_caseta.py to follow Home Assistant style guide.

Related issue (if applicable): None

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3310

Example entry for configuration.yaml (if applicable):

lutron_caseta:
    host: IP_ADDRESS

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@upsert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kfcook, @gurumitts and @arsaboo to be potential reviewers.

@pvizeli pvizeli merged commit c3a9100 into home-assistant:dev Sep 5, 2017
@balloob balloob mentioned this pull request Sep 7, 2017
@kfcook
Copy link
Contributor

kfcook commented Sep 14, 2017

I think something went wrong here. I did a pip3 install --upgrade homeassistant and the upgrader didn't pull down the latest version of pylutron. Everything looks correct in the requirements file, but the installer isn't pulling it down. Any thoughts?

@MartinHjelmare
Copy link
Member

pip3 install --upgrade homeassistant will only upgrade the core requirements, not the component requirements. That latter will happen after first start of hass during the setup process.

@MartinHjelmare
Copy link
Member

If there's an issue please open an issue.

@home-assistant home-assistant locked and limited conversation to collaborators Sep 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants