Skip to content

Conditional category for temperature sensor entities in AVM Fritz!Smarthome #98981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conditional category for temperature sensor entities in AVM Fritz!Smarthome #98981

merged 1 commit into from
Aug 30, 2023

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Aug 24, 2023

Proposed change

This will make the entity category for temperature sensors dependent on the device main function.
For a plug (eq. Fritz!DECT 210) it will be a diagnostic entity, because it is intended to check the device own, but not the room temperature.
For a smart button with H&T sensors (eq. Fritz!DECT 440) it will be main sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@mib1185 mib1185 added this to the 2023.8.5 milestone Aug 28, 2023
janiversen
janiversen approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

edenhaus
edenhaus approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mib1185 👍

@edenhaus edenhaus merged commit e7462e9 into home-assistant:dev Aug 30, 2023
@mib1185 mib1185 deleted the fritzbox/make-temperature-sensor-primary-for-sensor-devices branch August 30, 2023 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
@MartinHjelmare MartinHjelmare removed this from the 2023.8.5 milestone Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen janiversen approved these changes

@edenhaus edenhaus edenhaus approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed has-tests integration: fritzbox Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fritz!DECT 440 Temperature Sensor is not displayed in Area UI-Card
4 participants
@mib1185 @janiversen @edenhaus @MartinHjelmare