Skip to content

Added hold and double tap actions for tile card #18345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2023
Merged

Added hold and double tap actions for tile card #18345

merged 2 commits into from
Nov 30, 2023

Conversation

dsypniewski
Copy link
Contributor

@dsypniewski dsypniewski commented Oct 23, 2023 •
edited
Loading

Proposed change

Added hold and double tap actions for the Tile card
My personal use case is that I want both the tap and icon_tap actions to be toggle for a light but that leaves me without a quick access to more-info dialog, this solves that.
Based on the linked feature request it seems that I'm not the only one with similar problem.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: tile
tap_action:
  action: toggle
hold_action:
  action: more-info
double_tap_action:
  action: more-info
icon_tap_action:
  action: toggle
entity: light.kitchen

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@dsypniewski dsypniewski mentioned this pull request Oct 23, 2023
Merged
8 tasks
@dsypniewski dsypniewski force-pushed the tile-card-hold-and-double-tap branch from d17b4b1 to 6965e44 Compare October 23, 2023 15:04
@dsypniewski
Copy link
Contributor Author

@bramkragten Is there something I can do to help push this forward?

@dsypniewski dsypniewski force-pushed the tile-card-hold-and-double-tap branch from 6965e44 to ff91685 Compare November 24, 2023 11:01
@piitaya
Copy link
Member

piitaya commented Nov 29, 2023

Hello 👋
We discussed with UX team and we don't want to encourage users to use hold and double tap action because it can be difficult to perform on some device. However, we're not opposed to bring this feature as a YAML only feature for now. Could you take the editor part out of the PR?

@dsypniewski
Copy link
Contributor Author

@piitaya Done

piitaya
piitaya approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@piitaya piitaya merged commit f7f5029 into home-assistant:dev Nov 30, 2023
@N3rdix N3rdix mentioned this pull request Dec 1, 2023
Open
3 tasks
@martindybal
Copy link
Contributor

@dsypniewski @piitaya Thnak you for your effort. I use hold_action a lot in my dashboards. But there is one thing I don't like, when I long hold an icon, it doesn't become hold_action but icon_tap_action. Which is unexpected behavior for me. What if I add both icon_hold_action and icon_double_tap_action. I understand that this is a very complicated configuration, but I would not like to change the behavior that users may already be used to.

@martindybal martindybal mentioned this pull request Sep 11, 2024
Merged
9 tasks
@Mincka Mincka mentioned this pull request Mar 9, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piitaya piitaya piitaya approved these changes

Assignees
No one assigned
Labels
cla-signed hacktoberfest Tile card
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsypniewski @piitaya @martindybal @bramkragten