Update entity naming in entity picker #24971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfd9ca8 to
511e177
Compare
This comment was marked as abuse.
This comment was marked as abuse.
c27cafe to
76fb3b9
Compare
91e03a8 to
3e6455a
Compare
610b67b to
2844ff1
Compare
bramkragten
reviewed
Apr 17, 2025
bramkragten
reviewed
Apr 17, 2025
bramkragten
reviewed
Apr 17, 2025
| $or: this._fuseKeys.map((key) => ({ [key]: term })), | ||
| })), | ||
| }); | ||
| target.filteredItems = results.map((result) => result.item); |
There was a problem hiding this comment.
So there is no sorting by score, or is that done by fuse internal?
There was a problem hiding this comment.
Score is always 0. Fuse is unable to sort it as the query contains "or"
bramkragten
reviewed
Apr 17, 2025
bramkragten
reviewed
Apr 17, 2025
bramkragten
reviewed
Apr 17, 2025
d5af88c to
393bb51
Compare
bramkragten
reviewed
Apr 17, 2025
| @@ -57,6 +57,22 @@ export type HaEntityPickerEntityFilterFunc = (entity: HassEntity) => boolean; | |||
|
|
|||
| const CREATE_ID = "___create-new-entity___"; | |||
|
|
|||
| const DOMAIN_STYLE = styleMap({ | |||
There was a problem hiding this comment.
still don't understand why it has to be a styleMap, it is not dynamic?
There was a problem hiding this comment.
For maintenance. Having a string make it hard to read and maintain. It's now outside of the component so it will be computed only once
bramkragten
approved these changes
Apr 17, 2025
9 tasks
3 tasks
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Display entity name, device name, domain and area in the device picker.
When a entity is selected, the label is still the friendly_name. Only row items are changed.
The items are sorting by device name and entity name so the entity are grouped by device.
The entity ID not displayed because it's technical and it should not be needed for most users as more context has been added. However, you can still display it by enabling it with a dedicated setting in the profile.
It will end up with this result : the domain is removed and the entity is displayed in a third line.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: