Skip to content

Fix "unavailable" state in Area card #25063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025

Conversation

ildar170975
Copy link
Contributor

Breaking change

Proposed change

Fixed unavailable state for areaEntity & "averaged" entities.

When areaEntity = unavailable (temperature):
Before:
image

After:
image

When all "averaged" entities are unavailable (humidity):
Before:
image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review April 15, 2025 00:24
@piitaya
Copy link
Member

piitaya commented Apr 15, 2025

Hello 👋

In the heading card, we display unavailable sensor with a instead of hiding it to avoid hiding potential issue the user can fix.

CleanShot 2025-04-15 at 12 02 21

What do you think about using this pattern in the area card too?

@ildar170975
Copy link
Contributor Author

What do you think about using this pattern in the area card too?

I think this would be a nice alternative.
Please anyone from UX team - tell what is better, I will try to do it.

@piitaya piitaya requested a review from marcinbauer85 April 15, 2025 10:30
@silamon silamon added the Needs UX Pull requests requiring a review from the Home Assistant design team label Apr 24, 2025
@marcinbauer85
Copy link
Contributor

I'm very sorry @ildar170975 for the delay, I've completely missed this. Yes, please go ahead with this :)

@ildar170975
Copy link
Contributor Author

@marcinbauer85 thanks a lot for the feedback! Will continue work as soon as come back home!

@ildar170975 ildar170975 marked this pull request as draft May 13, 2025 20:37
@piitaya piitaya removed the Needs UX Pull requests requiring a review from the Home Assistant design team label May 22, 2025
@ildar170975 ildar170975 marked this pull request as ready for review May 29, 2025 14:45
@ildar170975
Copy link
Contributor Author

ildar170975 commented May 29, 2025

Now it gives this look:
изображение
Sorry for a long delay, have a very limited access to PC these days.

@MindFreeze MindFreeze merged commit a099e65 into home-assistant:dev May 31, 2025
15 checks passed
@ildar170975 ildar170975 deleted the area-card-unavail branch May 31, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Area card: icons are displayed for unavailable entities w/o values
5 participants