Skip to content

Use failed add-ons and folders of backup #25548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2025
Merged

Conversation

wendevlin
Copy link
Contributor

Proposed change

  • Refactor ha-backup-overview-summary.ts render, to deduplicate code
  • Use failed_addons and failed_folders in summary and backup detail

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin marked this pull request as ready for review May 21, 2025 11:55
@matthiasdebaat
Copy link
Collaborator

... wasn't able to store all folders / add-ons

Sounds a bit technical. Suggest to change the text to
" was not able to backup all folders / add-ons"

@wendevlin wendevlin requested a review from bramkragten May 26, 2025 13:07
@bramkragten bramkragten enabled auto-merge (squash) May 26, 2025 13:17
@bramkragten bramkragten merged commit bb5f01a into dev May 26, 2025
14 checks passed
@bramkragten bramkragten deleted the add-addon-backup-error branch May 26, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants