-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add severity level to dialog automation mode #25601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
variables?: Record<string, unknown>; | ||
} | ||
|
||
export type AutomationConfigMaxExceeded = "silent" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export type AutomationConfigMaxExceeded = "silent" | |
export type AutomationConfigMaxExceeded = (typeof automationConfigMaxExceededOptions)[number] | "notset"; |
@@ -158,6 +171,25 @@ class DialogAutomationMode extends LitElement implements HassDialog { | |||
` | |||
: nothing} | |||
|
|||
<div class="options"> | |||
<ha-select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only render this if the current mode is a max mode, so include it in the statement above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the docs it should also be valid in other modes:
When max is exceeded (which is effectively 1 for single mode) a log message will be emitted to indicate this has happened.
This is a pretty advanced setting, not sure if we should be putting this in the UI. And if we do, we probably want to hide it in a expandable or something... |
Let me know if you want me to continue and put it in expandable section. |
Breaking change
Proposed change
Add a severity level select in the dialog to change the automation mode.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: