Skip to content

hui-graph-footer-editor: add padding-bottom to prevent a scrollbar #25645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented May 29, 2025

Breaking change

Proposed change

Graph header/footer editor has a vertical scrollbar.
It appears since a mdc-switch__thumb-underlay element inside a ha-switch "goes beyond" it's space:
46px vs 48px:
изображение

изображение

Fixed this by adding a padding-bottom to a container.
Probably can be fixed by setting overflow: hidden to ha-switch instead - but decided not to touch it.

Before:
изображение

After:
изображение

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review May 29, 2025 17:47
@MindFreeze
Copy link
Contributor

I think we should fix the switch instead. Maybe not with overflow: hidden but by adjusting its margin, padding or box-sizing

@ildar170975
Copy link
Contributor Author

think we should fix the switch instead.

Tried some ways in Code inspector, did not like results. Will check again then this. Converting to draft.

@ildar170975 ildar170975 marked this pull request as draft May 30, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants