Skip to content

Show JS version and custom UIs in dev info #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2018
Merged

Conversation

c727
Copy link
Contributor

@c727 c727 commented Mar 11, 2018

  • add frontend JS version to dev info
  • add custom UI info to dev info

A problem with custom UIs is that users often run old, cached, versions. This shows the installed running version now.

Andrey already has this for his custom-ui. This should provide an interface for everyone

code to include in your custom-state-card:

const CUSTOM_UI_NAME = 'state-card-tiles';
const CUSTOM_UI_VERSION = '20180308';
const CUSTOM_UI_URL = 'https://github.com/c727/home-assistant-tiles';

if (!window.CUSTOM_UI_LIST) {
  window.CUSTOM_UI_LIST = [];
}
window.CUSTOM_UI_LIST.push({
  name: CUSTOM_UI_NAME,
  version: CUSTOM_UI_VERSION,
  url: CUSTOM_UI_URL
}); 

cui2

Copy link
Contributor

@andrey-git andrey-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for @balloob

@balloob
Copy link
Member

balloob commented Mar 11, 2018

Yeah I'm 👍 on this. Just not sure what's with the top "Custom UI's" in the screenshot? I don't see it in the code either? (I also think it shouldn't be there, just 1 place to render this data seems fine)

@@ -123,6 +123,19 @@
<p>
Path to configuration.yaml: [[hass.config.core.config_dir]]
</p>
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this under the version of Python/ Polymer ?

@c727
Copy link
Contributor Author

c727 commented Mar 11, 2018

@balloob "Custom UI 20180216" is added by Andrey's state-card where I got the inspiration for this - It's not included in this PR

@balloob balloob merged commit 198e2dd into master Mar 11, 2018
@balloob balloob deleted the c727-customui-version branch March 11, 2018 23:35
c727 added a commit to home-assistant/home-assistant.io that referenced this pull request Mar 12, 2018
Added instructions for custom UIs to show up in the HA dev info panel

home-assistant/frontend#981
fabaff pushed a commit to home-assistant/home-assistant.io that referenced this pull request Mar 12, 2018
…#4903)

* Update frontend_creating_custom_ui.markdown

Added instructions for custom UIs to show up in the HA dev info panel

home-assistant/frontend#981

* Use note class

* Update frontend_creating_custom_ui.markdown
cdce8p pushed a commit to cdce8p/ha-frontend that referenced this pull request Mar 15, 2018
* Show JS version and custom UIs in dev info

* Custom UIs

* Move to bottom
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants