Skip to content

For OneDrive Backup, maybe you should clarify if it can be unencrypted, as I suppose it's clear that it can be encrypted. #38452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CataCluj opened this issue Apr 9, 2025 · 10 comments · Fixed by #38542
Assignees

Comments

@CataCluj
Copy link

CataCluj commented Apr 9, 2025

Feedback

For OneDrive Backup, maybe you should clarify if it can be unencrypted, as I suppose it's clear that it can be encrypted.
Thank you.

URL

https://www.home-assistant.io/integrations/onedrive/

Version

2025.4.1

Additional information

No response

@home-assistant
Copy link

home-assistant bot commented Apr 9, 2025

Hey there @zweckj, mind taking a look at this feedback as it has been labeled with an integration (onedrive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onedrive can trigger bot actions by commenting:

  • @home-assistant close Closes the feedback.
  • @home-assistant rename Awesome new title Renames the feedback.
  • @home-assistant reopen Reopen the feedback.
  • @home-assistant unassign onedrive Removes the current integration label and assignees on the feedback, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information) to the feedback.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information) on the feedback.

@zweckj
Copy link
Member

zweckj commented Apr 9, 2025

I don't get your point tbh. You are saying it is clear, but still should be clarified? IMO this is not a topic for OneDrive specifically, but is rather explained in the general Backup documentation

@CataCluj
Copy link
Author

CataCluj commented Apr 9, 2025

Thank you @zweckj
I'll try again:
It's clear (from backup docs): It can be encrypted.
Not clear: it can be UN-encrypted.

@zweckj
Copy link
Member

zweckj commented Apr 9, 2025

I see. That still rather belongs on the general backup page imo (and is already there, but to be fair, with a misleading headline https://www.home-assistant.io/common-tasks/general/#downloading-your-local-backups)

@CataCluj
Copy link
Author

CataCluj commented Apr 9, 2025

I see that "The backup stored on Home Assistant Cloud is always encrypted."
I see that I can turn it off for the examples there, but they don't look like clouds to me, so I can't tell if ALL backup locations except that one can be un-encrypted.
Also, since the OneDrive integration documentation talks so much about backups (not a negative) it feels like it may have specific needs/abilities and it would be nice to know about encryption just by reading it.

@zweckj
Copy link
Member

zweckj commented Apr 10, 2025

The documentation says

"For each enabled location, select the cog  to enable/disable encryption.
Info: The backup stored on Home Assistant Cloud is always encrypted."

which to me seems pretty clear that every location except HA cloud can be unencrypted.

Also, since the OneDrive integration documentation talks so much about backups

well that's its main use-case

it feels like it may have specific needs/abilities

it does not

I am heavily biased here, because I've been working a lot with those things, so I'm not sure tbh how to formulate things in a way that it'd be clearer. But you're very welcome to open a PR on the docs with a suggestion.

@CataCluj
Copy link
Author

I agree, and stated so, that docs suggests all except one can be unencrypted.
I explained that "I see that I can turn it off for the examples there, but they don't look like clouds to me, so I can't tell if ALL backup locations except that one can be un-encrypted.". Maybe I should have added "ALL cloud backup locations", but may not change anything.
Anyway, it seems you feel stronger than me that it's all good, so I'll let it go.
Thank you.

@zweckj
Copy link
Member

zweckj commented Apr 10, 2025

I didn’t wanna discourage you, as I tried to explain I am very familiar with those things so it’s difficult to see what might be missing for me, hence why I am looking for concrete suggestions.

@CataCluj
Copy link
Author

CataCluj commented Apr 10, 2025 via email

@zweckj
Copy link
Member

zweckj commented Apr 15, 2025

I just wanted a line like "Backup encryption can be disabled as shown in the backup docs".

That we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants