Skip to content

Correct specification for radar site IDs #10148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2019
Merged

Correct specification for radar site IDs #10148

merged 2 commits into from
Aug 21, 2019

Conversation

michaeldavie
Copy link
Contributor

@michaeldavie michaeldavie commented Aug 15, 2019 •
edited by gitpod-io bot
Loading

Description:

Corrects formatting required for radar site ID code.

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Aug 15, 2019
@michaeldavie michaeldavie mentioned this pull request Aug 16, 2019
Merged
9 tasks
@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already labels Aug 16, 2019
@klaasnicolaas klaasnicolaas added the ready-for-review This PR needs to be reviewed label Aug 19, 2019
@klaasnicolaas
Copy link
Member

klaasnicolaas commented Aug 19, 2019 •
edited
Loading

Are the changes here related to the PR you mentioned? If so then the PR must be in the next branch.

@michaeldavie
Copy link
Contributor Author

It's a bit odd. I put this change against current as the current documentation is wrong and has led some users astray. The PR is against 0.98 and builds the same logic right into the configuration validation for the component, but the documentation won't change again as a result.

https://github.com/home-assistant/home-assistant/pull/25973/files#diff-2d0318432997ef9f5f0a927056a835afR39

I hope that helps.

@klaasnicolaas
Copy link
Member

klaasnicolaas commented Aug 19, 2019 •
edited
Loading

Not quite the answer I am looking for.

If the parent PR makes changes in the docs, then this PR must be in the next branch so that it comes online upon release. So I want to know if your changes in this PR are related to the current code in Home Assistant, only then does it belong to the current branch.

@michaeldavie
Copy link
Contributor Author

michaeldavie commented Aug 19, 2019 •
edited
Loading

Yes, this change affects the current code, 0.97. I've removed the link to the PR.

@klaasnicolaas klaasnicolaas added enhancement and removed has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already labels Aug 19, 2019
frenck
frenck approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @michaeldavie! And sorry for the misunderstanding there!

👍

@frenck frenck merged commit 61da52c into home-assistant:current Aug 21, 2019
@probot-home-assistant probot-home-assistant bot removed the ready-for-review This PR needs to be reviewed label Aug 21, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeldavie @klaasnicolaas @frenck