Skip to content

Add ViCare heating_type #10656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

Add ViCare heating_type #10656

merged 1 commit into from
Nov 4, 2019

Conversation

crazyfx1
Copy link
Contributor

@crazyfx1 crazyfx1 commented Oct 7, 2019

Description:

Pull request in home-assistant (if applicable): home-assistant/core#27296

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 7, 2019
@crazyfx1 crazyfx1 mentioned this pull request Oct 7, 2019
Merged
8 tasks
frenck
frenck approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Oct 9, 2019
@probot-home-assistant probot-home-assistant bot added the parent-merged The parent PR has been merged already label Nov 4, 2019
@frenck frenck merged commit c708996 into home-assistant:next Nov 4, 2019
@probot-home-assistant probot-home-assistant bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

+1 more reviewer

@oischinger oischinger oischinger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazyfx1 @frenck @oischinger