Skip to content

Conversation

bvlaicu
Copy link
Contributor

@bvlaicu bvlaicu commented Oct 11, 2019

Description:

Pull request in home-assistant (if applicable): home-assistant/core#27571

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant bot added next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 11, 2019
@klaasnicolaas klaasnicolaas added the new-integration This PR adds documentation for a new Home Assistant integration label Oct 11, 2019
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in another repo label Oct 11, 2019
Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
@bvlaicu bvlaicu requested a review from klaasnicolaas October 11, 2019 23:09
klaasnicolaas
klaasnicolaas previously approved these changes Oct 11, 2019
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged 👍

Happy Hacktoberfest! 🎉

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Oct 12, 2019
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Oct 13, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Oct 13, 2019
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Oct 16, 2019
@frenck frenck merged commit 6a232dc into home-assistant:next Oct 16, 2019
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants