Skip to content

Fixed sensor/Nest documentation to reflect the new mode attribute #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed sensor/Nest documentation to reflect the new mode attribute #1082

wants to merge 1 commit into from

Conversation

tchellomello
Copy link
Contributor

Fixed sensor/Nest documentation to reflect the new 'mode' attribute.

sensor:
  - platform: nest
    monitored_conditions:
      - 'temperature'
      - 'target'
      - 'humidity'
      - 'last_ip'
      - 'local_ip'
      - 'last_connection'
      - 'battery_level'
      - 'mode'
      - 'weather_condition'
      - 'weather_temperature'
      - 'weather_humidity'
      - 'wind_speed'
      - 'wind_direction'
      - 'co_status'
      - 'smoke_status'

Home Assistant PR home-assistant/core#3665

@tchellomello tchellomello mentioned this pull request Oct 3, 2016
Merged
4 tasks
@Landrash
Copy link
Contributor

Landrash commented Oct 3, 2016

If you could try to minimize the example configuration as in #1014 . If this already is the minimum then ignore this comment.

@tchellomello
Copy link
Contributor Author

Sure, I can make a shorter version tomorrow and submit.

Makes sense shorter examples for sure. +1

@Landrash Landrash added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 3, 2016
@tchellomello
Copy link
Contributor Author

@Landrash it seems @fabaff already minimized the configuration examples on commit 227d5a3.

So, I'm just rebasing my branch to add the correct attribute.

@Landrash
Copy link
Contributor

Landrash commented Oct 4, 2016

@tchellomello Do that and I'll merge this after the associated pull request goes trough.

@tchellomello
Copy link
Contributor Author

@Landrash I'm closing this PR because the attribute was intentionally renamed on 0.29. I've already fixed the PR home-assistant/core#3665 and there is no need to rename the attribute on the documentation anymore.
Since the configuration example is already minimized, I'm closing this one.
Thanks @Landrash

@tchellomello tchellomello deleted the fix_nest_issue_3624 branch October 4, 2016 15:27
@robbiet480 robbiet480 removed the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tchellomello @Landrash @robbiet480