Skip to content

Add Pushbullet and Home Assistant version to update notification #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

philhawthorne
Copy link
Contributor

Adds an example configuration for someone who wants to be alerted when a
new Home Assistant is released, and they would like the notification to
include the new Home Assistant version in the message.

Adds an example configuration for someone who wants to be alerted when a
new Home Assistant is released, and they would like the notification to
include the new Home Assistant version in the message.
title: 'New Home Assistant Release'
target: 'YOUR_TARGET_HERE' #See Pushbullet component for usage
message: "Home Assistant {{ states.updater.updater.state }} is now available."
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an empty line after for formatting to behave properly. With that exception this looks good!

@fabaff
Copy link
Member

fabaff commented Oct 4, 2016

The updater page contains already a very similar sample. What do you guys think of extending the updater example instead of an additional cookbook entry?

@Landrash
Copy link
Contributor

Landrash commented Oct 4, 2016

@fabaff Additional entries in the cookbook is a bad thing in my mind. Since many most likely use it as inspiration it might help as a example since this is a bit more complex.
A good compromise could be to retrofit the example on the updater page to show the release nr.
@philhawthorne How do you feel about it?

@robbiet480 robbiet480 added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 4, 2016
@philhawthorne
Copy link
Contributor Author

@Landrash extra line added.

So I have mixed feelings about that. In my search for finding out how to add the HA version to the notification, I had to look at examples from the Notify Platform. Pushbullet Platform, Templating, and this cookbook page. I didn't even know there was updater page with that example.

I knew from the Cookbook I wanted a notification when there was a new HA release. So in my opinion, it makes sense that this example goes into the cookbook. Otherwise, if someone was in my shoes and wants to include the HA version in the notification, they'll need to look outside of that page to get the template example. After all, both examples are achieving the same thing, notification of a new HA release.

Perhaps this example could also be added to the updater page. However that just means more duplicate examples that need to be maintained.

@Landrash
Copy link
Contributor

Landrash commented Oct 5, 2016

Good point @philhawthorne. Lets add this then =)

@Landrash Landrash merged commit 967ace4 into home-assistant:next Oct 5, 2016
philhawthorne added a commit to philhawthorne/home-assistant.github.io that referenced this pull request Oct 9, 2016
The template example introduced in home-assistant#1100 needs some tags around the
template tags so that Jekyll doesn't try to interpret the code.
philhawthorne added a commit to philhawthorne/home-assistant.github.io that referenced this pull request Oct 9, 2016
The template example introduced in home-assistant#1100 needs some tags around the
template tags so that Jekyll doesn't try to interpret the code.
Landrash pushed a commit that referenced this pull request Oct 9, 2016
…1195)

The template example introduced in #1100 needs some tags around the
template tags so that Jekyll doesn't try to interpret the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants